Convert zaphod-config to a module. #17
Conversation
Much like a hitchhiker and their towel, a module with boards or shields in it needs to know where its board_root is.
Merge Zaphod config module-ification to `main` on this fork.
|
If the README is extraneous, feel free to drop it |
I definitely meant for it to be zaphod-config in the first place. Co-authored-by: Pete Johanson <[email protected]>
… a module. (#2) * Copying ZAPHOD_BONGO_CAT config declaration into Kconfig.shield, duplicating what is in plain Kconfig. * Updating include directories for Zephyr stuff: kernel.h and logging/log.h * Trying to build things up one step at a time. * Fix module name. * Selecting LV_USE_IMG when ZMK_DISPLAY is enabled on zaphod_lite. * In newer versions of Zephyr, the logging header is under a zephyr directory. * Change LVGL to LV in config selections. * Update Bongo Cat widget for LVGL 8.3 - there is no longer a `lv_anim_value_t` typedef, but `int32_t` works for indexing images in animator functions. - `lv_image_create` only takes one parameter now: the parent object. - `lv_img_set_auto_size` no longer exists. * Minor whitespace cleanup. * Setting width and height to LV_SIZE_CONTENT for auto-sizing. I think the object might already be auto-sized by default, but it can't hurt to be explicit about it. * Removing LV_USE_IMG from defconfig since it is in the main Kconfig Images and animation are only needed by this shield if the Bongo Cat WPM widget is enabled. That selection is handled in boards/shields/zaphod_lite/Kconfig itself. * Reverting Kconfig.shield changes. The configurations in plain Kconfig ought to be sufficient. * Revert "Reverting Kconfig.shield changes." This reverts commit 9c7761d. * Repeating LVGL -> LV correction in Kconfig.shield
Thanks! I fixed the module name, and also made some code modifications to get things compiling with Zephyr 3.5.0 and LVGL 8.3. If it would be better to split "module stuff" and "widget compatibility stuff" into separate PRs, let me know. I think it shouldn't be too hard to tease the two apart if needed. |
|
Can we fix up the GHA build file to use the standard one while we are at it? |
I will take a look! It should just use the same one from |
|
One thing I do not fully understand is why copying the |
Adds a
zephyr/module.ymlfile to zaphod-config so that other zmk-config repos can reference it as a Zephyr module.