Added kml download functionality #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergardfjall
requested changes
Oct 5, 2020
| @@ -16,16 +15,15 @@ | |||
| def incremental_backup(username: str, | |||
| password: str = None, | |||
| backup_dir: str = os.path.join(".", "activities"), | |||
| export_formats: List[str] = None, | |||
| export_formats: str = 'ALL', | |||
There was a problem hiding this comment.
This is supposed to be a list of str, so I would suggest switching the type annotation back.
We could have the default be supported_export_formats instead.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported_export_formatsandformat_suffixin backup.pydownload()function in backup.pydef get_activity_kml()function in garminclient.pyincremental_backup()in incremental_backup.py to include kml