Python 3 compatibility #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2015 14:31
Just ran 2to3 on the codebase so this version should be compabible with both Python 2 and 3.
| @@ -191,7 +191,7 @@ def get_params_tuples(self): | |||
| """ | |||
| tuple_list = [] | |||
| if len(self.params) > 0: | |||
| for param in self.params.keys(): | |||
| for param in list(self.params.keys()): | |||
There was a problem hiding this comment.
Isn't this simply: for param in self.params: in both Python 2 and 3? Getting a list of keys for a dictionary isn't necessary in Python. For repeatability, think about using for param in sorted(self.params):
There was a problem hiding this comment.
Yes you are right, there is not need of the list() to run this in Python 3. Just run the automatic 2to3 converter so I'm not sure why the converter thought you can't just iterate over the keys without creating a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran 2to3 on the codebase so this version should be compabible with
both Python 2 and 3.