Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: address feedback for Fedora package #36

Merged

Conversation

emansom
Copy link
Contributor

@emansom emansom commented Apr 13, 2024

This PR addresses feedback by @NeilHanlon from the Fedora package review request upstream here.

It was tedious to get the packaging thing to work alright, I opted for a semi hack in __init__.py as for some reason I couldn't get the setuptools packaged with EL to expand smfc.py to a full namespace. Inform me if there's a better way: i'm very much a novice in Python.

Multiple Python build system compatibility layers are implemented: that's why there's an setup.cfg, setup.py and pyproject.toml that all contain the same definitions. This is to get the same behavior across all distros: EL ships with old setuptools and old pyproject that don't behave the same as their latest versions would.

Split the files for better maintainability and sanity. Currently this does break the Docker support, will fix this before merge (hence it's a draft).

Per feedback I have replaced all /opt references with /etc. The .spec file has further been enhanced to build and test the smfc code. Package has also been split in two: smfc and python3-smfc as dependency.

The file structure has been altered to a flat package structure to make pyproject happy. Further several system-wide files have been moved to more descriptive directories.

@emansom emansom force-pushed the bugfix/address-rhel-feedback branch 7 times, most recently from f703805 to 89cb40b Compare April 13, 2024 23:40
@emansom emansom force-pushed the bugfix/address-rhel-feedback branch 12 times, most recently from 537b695 to 028580b Compare April 14, 2024 03:37
@petersulyok petersulyok marked this pull request as ready for review April 14, 2024 18:37
@petersulyok
Copy link
Owner

Fundamental changes. I will move the PR to a branch while it is stabilizing and I understand what is happening.

@emansom emansom force-pushed the bugfix/address-rhel-feedback branch from 028580b to 2acb602 Compare April 14, 2024 19:26
@emansom emansom changed the base branch from main to tito_rpm_support April 17, 2024 06:08
@petersulyok petersulyok merged commit d2fd025 into petersulyok:tito_rpm_support Aug 23, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants