Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple batteries #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mark7
Copy link

@mark7 mark7 commented Apr 28, 2018

Previously, only data on the first battery found was collected. Some
laptops (like the Thinkpad T470) have multiple batteries, resulting in
the charge from only one being logged.

Treat all batteries as one large "aggregate" battery and store data on
its charge.

Previously, only data on the first battery found was collected.  Some
laptops (like the Thinkpad T470) have multiple batteries, resulting in
the charge from only one being logged.

Treat all batteries as one large "aggregate" battery and store data on
its charge.
@petterreinholdtsen
Copy link
Owner

I would imagine it make more sense to record information about each battery individually. Why do you believe it make sense to store the combined values?

@mark7
Copy link
Author

mark7 commented Apr 29, 2018

Well:

  • Existing software that I use, like i3status, aggregates the charge.

  • Multiple separate batteries would require UI and logging changes (e.g. all the commands would need to be parameterized on individual battery), whereas an aggregate battery permits continuing to use the software as-is. I can't say that there's no chance that someone would have a use for treating them separately (e.g. if someone physically swaps batteries, which is one thing that someone can do with a laptop with multiple batteries), but I simply am interested in how much life the laptop as a whole has remaining -- the location of the individual charge isn't very interesting, but how much longer the laptop as a whole has to run is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants