TWCCMan evaluates recovery pct for FEC #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishaBaranov
force-pushed
the
misha/twcc_fec_stats
branch
2 times, most recently
from
0b04a8b
to
b8bd262
Compare
MishaBaranov
force-pushed
the
misha/twcc_fec_stats
branch
from
b8bd262
to
373ba36
Compare
MishaBaranov
force-pushed
the
misha/twcc_fec_stats
branch
from
373ba36
to
bb19396
Compare
Major rework of twcc manager internals caused by need to evaluate recovery percentage in case of FEC. Sent Packet structs are stored GstQueueArray to keep their pointers persistent. TWCC feedback parser creates a list of packets updated by this feedback, which then is passed into statistic gathering context. Then the remaining work is done in get_windowed_stats call.
MishaBaranov
force-pushed
the
misha/twcc_fec_stats
branch
from
bb19396
to
c475446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major rework of twcc manager internals
caused by need to evaluate recovery
percentage in case of FEC.
RTX and FEC packets which are about to be sent are augmented with RepairMeta metadata, containing an array of data packets seqnums and SSRC (not twcc seqnum!) this particular packet covers.
Then TWCC Manager tracks Sent Packet structs by storing them in GstQueueArray to keep their pointers persistent. TWCC feedback parser creates a list of packets updated by this feedback, which then is passed into statistic gathering context.
Then the remaining work is done in get_windowed_stats call:
original seqnum→twcc seqnum