-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vendor SDK 2.2.0/3.0.0 #344
base: master
Are you sure you want to change the base?
Conversation
Thanks for the patches! To reply something: Recently, I didn't have a chance to work ESP8266 any longer. This project was always set up in conservative manner, i.e. I personally tested all the changes work as expected before making them the default. It's also my assumption that there're project which rely on such treatment. So:
If you have any feedback/suggestions, please share it. |
@pfalcon could you share how you plan to test those changes? maybe somebody else can fill in the testing bit. It'd be a shame to not have support for the later SDKs which have a nice set of bugfixes and new features. |
My default testcase is MicroPython esp8266 port, see e.g. discussion here: micropython/micropython#4295 |
I tested it on Debian 9, works OK.
I'm able to build my project and all works OK. |
Not work on Ubuntu 19.10 DISTRIB_ID=Ubuntu /xxx/Espruino/esp-open-sdk/sdk/lib/libmain.a(app_main.o): In function |
@goodkiller starting from SDK 3.0 user has to initialize partition table inside So, in your program you have to define |
Alternately, a fork with the minimal set of changes to get a clean build on Ubuntu 21.10 of an apparently working toolchain can be found here: #391 A maintained fork with more-current versions of things, such as https://github.com/esp-open-sdk/esp-open-sdk or https://github.com/someburner/esp-open-sdk, may be a better option. I'm offering a minimally-tweaked option for those who prefer that, or for comparison purposes if for some reason the newer tools don't work for you, or whatever. If your code doesn't work with either the updated toolchain or the minimally-tweaked one, then the problem is more likely in your code, rather than the toolchain... |
I've added support for Espressif's SDK v2.2.0. I've tested this on Ubuntu 16.04 and 18.04.