Fix lint errors & Introduce lint workflow (#76)

* Fix lint errors

* Add Actions workflow to lint Go code

.github/workflows/ci.yaml

@@ -24,6 +24,17 @@ jobs:
     - uses: actions/checkout@v4
     - run: make docker-build
 
+  lint-go:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-go@v5
+      with:
+        go-version-file: "go.mod"
+    - uses: golangci/golangci-lint-action@v6
+      with:
+        version: v1.59
+
   lint-chart:
     runs-on: ubuntu-latest
     steps:

webhooks/mutatepod_parts.go

@@ -6,7 +6,7 @@ import (
 
 	"github.com/MakeNowJust/heredoc"
 	corev1 "k8s.io/api/core/v1"
-	"k8s.io/utils/pointer"
+	"k8s.io/utils/ptr"
 )
 
 // Volumes
@@ -54,7 +54,7 @@ func k8sSATokenVolume(
 						Path:              K8sSATokenName,
 					},
 				}},
-				DefaultMode: pointer.Int32(defaultMode),
+				DefaultMode: ptr.To(defaultMode),
 			},
 		},
 	}
@@ -75,7 +75,7 @@ func (m *GCPWorkloadIdentityMutator) externalCredConfigVolume(defaultMode int32)
 						},
 					},
 				},
-				DefaultMode: pointer.Int32(defaultMode),
+				DefaultMode: ptr.To(defaultMode),
 			},
 		},
 	}
@@ -89,7 +89,7 @@ func gcloudSetupContainer(
 ) corev1.Container {
 	// for Restricted Profile in Pod Security Standards
 	securityContext := &corev1.SecurityContext{
-		AllowPrivilegeEscalation: pointer.Bool(false),
+		AllowPrivilegeEscalation: ptr.To(false),
 		Capabilities: &corev1.Capabilities{
 			Drop: []corev1.Capability{
 				"ALL",

webhooks/mutatepod_test.go

@@ -10,7 +10,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/utils/pointer"
+	"k8s.io/utils/ptr"
 )
 
 var _ = Describe("GCPWorkloadIdentityMutator.mutatePod", func() {
@@ -34,13 +34,13 @@ var _ = Describe("GCPWorkloadIdentityMutator.mutatePod", func() {
 		}
 	})
 	When("passed Pod has unparsed token expiration annotation", func() {
-		It("should reaise error", func() {
+		It("should raise error", func() {
 			idConfig := GCPWorkloadIdentityConfig{
 				WorkloadIdentityProvider: &workloadIdentityProviderFmt,
-				ServiceAccountEmail:      pointer.StringPtr(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
-				Audience:                 pointer.String("my-audience"),
-				TokenExpirationSeconds:   pointer.Int64(10000),
-				RunAsUser:                pointer.Int64(1000),
+				ServiceAccountEmail:      ptr.To(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
+				Audience:                 ptr.To("my-audience"),
+				TokenExpirationSeconds:   ptr.To[int64](10000),
+				RunAsUser:                ptr.To[int64](1000),
 			}
 			pod := &corev1.Pod{
 				ObjectMeta: metav1.ObjectMeta{
@@ -58,10 +58,10 @@ var _ = Describe("GCPWorkloadIdentityMutator.mutatePod", func() {
 		It("should replace reqiured fields and override configurations", func() {
 			idConfig := GCPWorkloadIdentityConfig{
 				WorkloadIdentityProvider: &workloadIdentityProviderFmt,
-				ServiceAccountEmail:      pointer.StringPtr(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
-				Audience:                 pointer.String("my-audience"),
-				TokenExpirationSeconds:   pointer.Int64(10000),
-				RunAsUser:                pointer.Int64(1000),
+				ServiceAccountEmail:      ptr.To(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
+				Audience:                 ptr.To("my-audience"),
+				TokenExpirationSeconds:   ptr.To[int64](10000),
+				RunAsUser:                ptr.To[int64](1000),
 			}
 			pod := &corev1.Pod{
 				ObjectMeta: metav1.ObjectMeta{
@@ -178,7 +178,7 @@ var _ = Describe("GCPWorkloadIdentityMutator.mutatePod", func() {
 		It("should mutate required fields", func() {
 			idConfig := GCPWorkloadIdentityConfig{
 				WorkloadIdentityProvider: &workloadIdentityProviderFmt,
-				ServiceAccountEmail:      pointer.StringPtr(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
+				ServiceAccountEmail:      ptr.To(fmt.Sprintf("sa@%s.iam.gserviceaccount.com", project)),
 			}
 			pod := &corev1.Pod{
 				Spec: corev1.PodSpec{

webhooks/mutator.go

@@ -89,7 +89,11 @@ func (m *GCPWorkloadIdentityMutator) SetupWithManager(ctx context.Context, mgr c
 		logger.Error(err, "Failed to get ServiceAccount informer")
 		return err
 	}
-	saInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{})
+
+	if _, err = saInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{}); err != nil {
+		logger.Error(err, "Failed to add event handler")
+		return err
+	}
 
 	// Inject logger, decoder, and client.
 	m.logger = mgr.GetLogger()