Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysutils/pfSense-Status_Monitoring: add toggle for sorting views. Implement #13160 #1167

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

luckman212
Copy link
Contributor

redo of #1166 -- see pfSense redmine #13160

image

@jim-p
Copy link
Contributor

jim-p commented May 13, 2022

Looks good, thanks!

@luckman212
Copy link
Contributor Author

@jim-p Is there a way I can manually add this via System Patches until it gets merged? I tried using the full commit URL 1fff849 but that doesn't work obviously because the paths don't line up.

@luckman212
Copy link
Contributor Author

@jim-p Nevermind. I figured it out, just had to manually edit the patch to fix the paths and stripcount. 👍

@luckman212
Copy link
Contributor Author

Is this gonna make it into 22.05?

@jim-p
Copy link
Contributor

jim-p commented Jun 14, 2022

No, nothing else is being merged or added unless it's a major show stopper/release blocker at this point.

@luckman212
Copy link
Contributor Author

@jim-p Today, over a year later, I found myself scratching my head looking around at a customer's firewall trying to find where this setting was. Finally realized it doesn't exist. If I fix the conflicts, does this have potential to be merged in 23.09?

@jim-p
Copy link
Contributor

jim-p commented Jul 19, 2023

@jim-p Today, over a year later, I found myself scratching my head looking around at a customer's firewall trying to find where this setting was. Finally realized it doesn't exist. If I fix the conflicts, does this have potential to be merged in 23.09?

Yeah, if it can be fixed to apply cleanly we can pull it in. It was just bad timing before. After that release we all got deep into fixing things for PHP/FreeBSD 14 things and by the time we got past that a lot of PRs ended up with conflicts.

@luckman212
Copy link
Contributor Author

Okay thanks. I'm carving out a couple of weeks this summer to dust off a few PRs that I've had in my queue for a long time. Hope I can lob a few of them in there. 🙏

@marcos-ng marcos-ng changed the title add toggle for sorting Monitoring (RRD) views in pfSense sysutils/pfSense-Status_Monitoring: add toggle for sorting views Oct 24, 2024
@marcos-ng marcos-ng changed the title sysutils/pfSense-Status_Monitoring: add toggle for sorting views sysutils/pfSense-Status_Monitoring: add toggle for sorting views. Implement #13160 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants