-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysutils/pfSense-Status_Monitoring: add toggle for sorting views. Implement #13160 #1167
base: devel
Are you sure you want to change the base?
Conversation
Looks good, thanks! |
@jim-p Nevermind. I figured it out, just had to manually edit the patch to fix the paths and stripcount. 👍 |
Is this gonna make it into 22.05? |
No, nothing else is being merged or added unless it's a major show stopper/release blocker at this point. |
@jim-p Today, over a year later, I found myself scratching my head looking around at a customer's firewall trying to find where this setting was. Finally realized it doesn't exist. If I fix the conflicts, does this have potential to be merged in 23.09? |
Yeah, if it can be fixed to apply cleanly we can pull it in. It was just bad timing before. After that release we all got deep into fixing things for PHP/FreeBSD 14 things and by the time we got past that a lot of PRs ended up with conflicts. |
Okay thanks. I'm carving out a couple of weeks this summer to dust off a few PRs that I've had in my queue for a long time. Hope I can lob a few of them in there. 🙏 |
redo of #1166 -- see pfSense redmine #13160