Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/pfSense-pkg-pfBlockerNG-devel: additional logging for MaxMind update failures #1342

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

DoubleStrike
Copy link

This adds specific messages to show that the files either existed or that the API key is empty.

Without these messages, the action just silently fails without logging anything to the window/log.

@BBcan177
Copy link
Contributor

BBcan177 commented Sep 2, 2024

I don't know if this would be of benefit. If the user enters the Account and Key, I don't see a benefit to log it each time cron runs?

@DoubleStrike
Copy link
Author

I don't know if this would be of benefit. If the user enters the Account and Key, I don't see a benefit to log it each time cron runs?

I've had issues on multiple installs where it would not update the local file because it thought it already existed. By adding this log message I was able to see why the update wasn't working and trigger it manually via the PHP DC command. A simple one-liner to the log to show why the update didn't happen seems rather useful for a very small trade-off of log size increase.

@marcos-ng marcos-ng changed the title Add specific log messages when MaxMind updates fail net/pfSense-pkg-pfBlockerNG-devel: additional logs when MaxMind updates fail Oct 24, 2024
@marcos-ng marcos-ng changed the title net/pfSense-pkg-pfBlockerNG-devel: additional logs when MaxMind updates fail net/pfSense-pkg-pfBlockerNG-devel: additional logging for MaxMind update failures Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants