Adding DNS Resolver module #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opoplawski
requested changes
Dec 23, 2023
|
Thank you for the submission! |
opoplawski
requested changes
Dec 30, 2023
opoplawski
force-pushed
the
master
branch
2 times, most recently
from
ebb5dbc
to
9ebb4c3
Compare
opoplawski
approved these changes
Jan 3, 2024
|
Thank you for the contribution! |
|
BTW - in the future, please use a separate branch instead of master to submit PRs from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled the majority of this from a fork by @chris-cyliu . The biggest changes from there were:
I ran into some issues setting up a test VM (not the greatest with networking), so it could probably use a little more. I also missed some settings when I compared them to the GUI, but have them noted in the code. Any feedback or suggestions are very welcome.
related to: #17