Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require for ruby 3.4.0-preview1|2 #320

Closed
wants to merge 1 commit into from

Conversation

chaadow
Copy link

@chaadow chaadow commented Oct 12, 2024

This require is causing issues in ruby 3.4.0-preview1 and 2. it does not require a real file

here is the error stack trace ( the error stems from this from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/gems/3.4.0+0/bundler/gems/pg_query-f23f1dfe39c6/lib/pg_query.rb:7:in '<main>'

/Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundled_gems.rb:76:in 'Kernel.require': dlsym(0x85a08d50, ruby_abi_version): symbol not found - ruby_abi_version (LoadError)
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel#replace_require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/gems/3.4.0+0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in 'Kernel#require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/gems/3.4.0+0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:34:in 'Kernel#require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/gems/3.4.0+0/bundler/gems/pg_query-f23f1dfe39c6/lib/pg_query.rb:7:in '<main>'
        from <internal:/Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require'
        from <internal:/Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel.replace_require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/gems/3.4.0+0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:34:in 'Kernel.require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundler/runtime.rb:65:in 'block (2 levels) in Bundler::Runtime#require'
        from <internal:array>:42:in 'Array#each'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundler/runtime.rb:60:in 'block in Bundler::Runtime#require'
        from <internal:array>:42:in 'Array#each'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundler/runtime.rb:52:in 'Bundler::Runtime#require'
        from /Users/chedli/.rbenv/versions/3.4.0-preview2/lib/ruby/3.4.0+0/bundler.rb:213:in 'Bundler.require'

@lfittl
Copy link
Member

lfittl commented Nov 26, 2024

Thanks for the contribution, however I'm not sure this is the right change to make, since I believe the require is needed to load the shared library (though I could be wrong). Somehow CI also didn't run on this PR, so this will need further investigation/testing.

@chaadow
Copy link
Author

chaadow commented Nov 27, 2024

@lfittl hi, regarding CI it's probably a GitHub Actions inactivity issue, in which GitHub automatically disables CI after say 2 or 3 months of inactivity ( I don't recall the exact period )

The solution would be to re enable CI in settings ( this happened to many other inactive gems I've contributed to recently )

Thanks for your reply

@Petercopter
Copy link

Bump. Still a problem in 3.4.0-rc1 and pg_query ~> 6.0

@msakrejda
Copy link
Contributor

Hi, Maciek from pganalyze here. I think the issue may actually be the 30d timeout on workflow approval for first-time contributors (see GH docs). Since pending workflows older than 30d are deleted, there's nothing to approve anymore. Could you try rebasing this branch or opening a new PR to trigger a new workflow run?

@PikachuEXE
Copy link

Opened #322

@msakrejda
Copy link
Contributor

Closing in favor of #322—let's see what CI says and move the discussion there. Thanks for the contribution.

@msakrejda msakrejda closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants