Clean up library with is_non_null
#1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
add-pointer-ext
branch
from
caac2ee
to
c45e485
Compare
|
Definitely! I will remove all |
NotGyro
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
This does seem clearer. Particularly, null_mut could be misunderstood as some mutable null - for example, if a C programmer in a hurry thought it was equivalent to a void*.
is_non_null() has none of that ambiguity, and seems much better to me. This change looks good.
|
I searched for |
workingjubilee
changed the title
!= null() by is_non_null
|
(i was trying to figure out why it wasn't in the core already - apparently there are some discussions about |
workingjubilee
changed the title
!= null() by is_non_nullis_non_null
|
🚲 🏚️ 🖌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
PointerExt::is_non_nulland cleans up some of the list code. I am told this is more readable?