Made SPI query arguments type safe #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I guess it's leftover from the time when I tried to play with generics and avoid a breaking change. That was required by the compiler for the type deduction, but can be reduced now. |
|
I appreciate your efforts on this area of pgrx, btw. Spi is incredibly hard to get right in C, and it’s not any easier in Rust. |
eeeebbbbrrrr
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
This is really nice, @YohDeadfall. Really nice.
Very clean.
Like @workingjubilee said somewhere, I think we'd want to hold this for v0.13, but I think this PR is a motivator for getting there quickly.
|
@YohDeadfall Can you resolve the conflicts? |
|
Sure! Actually, I just wanted to write you about this pull request too (: |
YohDeadfall
force-pushed
the
type-safe-query
branch
from
df050ab
to
56ceb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.