Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-atomic SPI connection #1876

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

YohDeadfall
Copy link
Contributor

Here's my take on making non-atomic SPI connections, but it lacks tests as I don't understand how to properly make them without dealing with portals directly. If I'm not wrong there were tests using a client to issue requests to the server with the required extensions, so it should be like that then.

@eeeebbbbrrrr
Copy link
Contributor

What's the use case for non-atomic SPI?

@YohDeadfall
Copy link
Contributor Author

It's used primarily if not only by language handlers which take that information from the current call. The problem I see is that the native API allows opting-in into non-atomic connections using SPI_connect_ext, but the provided implementation is less flexible, but more sound because with atomic connections no transaction control functions are allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants