-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow empty value for /pgf/arrow keys/fill #1352
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a Changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a typo on line 830, option -> options:
- When you use both the |color| and |fill| option, the |color| option must
+ When you use both the |color| and |fill| options, the |color| option must
e96729a
to
d715236
Compare
Signed-off-by: Henri Menke <[email protected]> Co-authored-by: Yukai Chou <[email protected]> Co-authored-by: Romano Giannetti <[email protected]>
Add a new type of arrow to help drawing Jack connectors Fixes #806 See also pgf-tikz/pgf#1352 Thanks to @Skillmon pgf-tikz/pgf#1348 (comment)
@@ -510,12 +510,14 @@ | |||
fill/.code={% | |||
\def\pgf@temp{#1}% | |||
\ifx\pgf@temp\pgf@nonetext% | |||
\pgfarrowsaddtooptions{\pgfarrowopentrue} | |||
\pgfarrowsaddtooptions{\pgfarrowopentrue}% | |||
\else\ifx\pgf@temp\pgfutil@empty% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems consistency beats no more unnecessary %
...
@hmenke Do you think this needs a new test? |
Motivation for this change
Fixes #1348
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: