Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHC0010012B] Workflow executions: End to end integration test #621

Merged
merged 8 commits into from
May 31, 2024

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented May 29, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

Adds a new github actions test which downloads/runs sapporo and tests a full workflow execution life cycle.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

The test can be run locally with an updated Sapporo setup.

  1. Make sure you have the latest version of the irida-next branch from phac-nml/sapporo-service https://github.com/phac-nml/sapporo-service/tree/irida-next
  2. Use the updated commands to start sapporo https://github.com/phac-nml/sapporo-service/blob/irida-next/README.irida-next.md
  3. Then run just the integration test
bin/rails test test/integration/sapporo.rb

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@JeffreyThiessen JeffreyThiessen self-assigned this May 29, 2024
@JeffreyThiessen JeffreyThiessen added the security Security related features and/or fixes label May 29, 2024
@JeffreyThiessen JeffreyThiessen force-pushed the workflow-executions/end-to-end-test branch from 278cb39 to 2af5dc0 Compare May 30, 2024 16:45
Copy link

Simplecov Report

Covered Threshold
92.36% 90%

@JeffreyThiessen JeffreyThiessen added the ready for review Pull request is ready for review label May 30, 2024
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit f8563c3 into main May 31, 2024
3 checks passed
@ericenns ericenns deleted the workflow-executions/end-to-end-test branch May 31, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review security Security related features and/or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants