Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Add isPuid query #625

Merged
merged 7 commits into from
Jun 14, 2024
Merged

GraphQL: Add isPuid query #625

merged 7 commits into from
Jun 14, 2024

Conversation

malchua
Copy link
Contributor

@malchua malchua commented Jun 3, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds in a new query named isPuid which returns True if the id given is in puid format. The query determines this from the id argument given.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Launch server and login as your preferred user
  2. Navigate to GraphiQL endpoint (e.g. http://localhost:3000/graphiql)
  3. Try the isPuid query using sample id
{
  isPuid(id: "INXT_SAM_245HANDHG5")
}
  1. Try the isPuid query using sample id
{
  isPuid(id: "INXT_SAM_245HANDHG865")
}
  1. Try querying an id for either a Sample, Attachment, Group, or Namespace::ProjectNamespace

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@malchua malchua added ready for review Pull request is ready for review graphql GraphQL API related changes labels Jun 3, 2024
@malchua malchua self-assigned this Jun 3, 2024
@malchua
Copy link
Contributor Author

malchua commented Jun 4, 2024

Hi, just to update, I'm currently working on the failed tests right now. So no need to review yet.

Copy link

github-actions bot commented Jun 5, 2024

Simplecov Report

Covered Threshold
92.41% 90%

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just one minor comment that needs to be updated

app/graphql/resolvers/is_puid_resolver.rb Outdated Show resolved Hide resolved
@ericenns ericenns merged commit 4ed99dd into main Jun 14, 2024
3 checks passed
@ericenns ericenns deleted the graphql/puid_query branch June 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql GraphQL API related changes ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants