Fix: Metadata Fields retrieval for Shared Groups and Shared Projects [DFCT0010073] #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group model and update metadata concern to use new method
ericenns
force-pushed
the
fix/metadata-fields_for_namespace-method
branch
from
a23f0ce to
6e42bda
Compare
deepsidhu85
previously approved these changes
Jun 5, 2024
ericenns
force-pushed
the
fix/metadata-fields_for_namespace-method
branch
from
6e42bda to
a2c2e02
Compare
ericenns
force-pushed
the
fix/metadata-fields_for_namespace-method
branch
from
a2c2e02 to
e7c9566
Compare
Simplecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
When launching a Workflow Execution from the Group Samples page when the Samples come from a shared Project or a shared Group. The metadata fields dropdown would not populate. Also when toggling the metadata on the same Group Samples page no metadata would show from the Samples even though they contained it.
This PR adds in a new method
metadata_fieldsto Namespace model with override in Group model. The override in the Group model will query the Shared Groups and Shared Projects to include their metadata fields in the result of the method.Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.