Data Table: Bot Accounts

[ChrisHuynh333]

What does this PR do and why?

Note: Due to the size of this current PR, the following will be branched out and fixed in separate PRs:

• Removal of new PAT panel upon bot deletion and PAT revoke

This PR refactors the bot account pages (Group and Project) to use the data_table_component (includes PAT tables to use data_table_component). This required much of the response logic (turbo etc.) to be re-done.

Screenshots or screen recordings

How to set up and validate locally

Test all bot functionality:

1. Create new bot (table updates with new bot and new PAT panel appears/updates)
2. Delete bot (table updates, empty state appears if there are 0 bots)
3. Active PATs for a bot and Revoke action (empty state of PAT table once all PATs are revoked)
4. Generate new PAT (table active PAT # updates, new PAT panel appears/updates)

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the PR acceptance checklist for this PR.

[joshsadam]

This looks really great overall.  I actually only have one wording change I would like to see.

[deepsidhu85]

Looks good to me!

[joshsadam]

I found a minor UI bug that I am hoping you can fix, and I am hoping that I can explain it properly. I will paste the screenshot and try to explain below.

• The div highlighted in the developer console wraps a turbo-frame.
• When the turbo frame is empty (as in the screenshot) the div is empty but still renders and has the class of mb-4 which for all purposes makes the margin bottom on the header 8.
• Can you remove the wrapping div and set the mb-4 on the content within the turbo-frame so that it is only there if the turbo-frame has content?

[joshsadam]

This looks good. I left 2 comments that I am hoping you can quickly fix. Good work on this.

[ChrisHuynh333]

I found a minor UI bug that I am hoping you can fix, and I am hoping that I can explain it properly. I will paste the screenshot and try to explain below.

• The div highlighted in the developer console wraps a turbo-frame.
• When the turbo frame is empty (as in the screenshot) the div is empty but still renders and has the class of mb-4 which for all purposes makes the margin bottom on the header 8.
• Can you remove the wrapping div and set the mb-4 on the content within the turbo-frame so that it is only there if the turbo-frame has content?

Thanks, removed the wrapper and moved the mb-4 to the frame content for both projects and groups in f039c40

[joshsadam]

This looks good to me

[github-actions]

Code Metrics Report

Coverage	Test Execution Time
92.7%	9m49s

Code coverage of files in pull request scope (99.1%)

Files	Coverage
app/components/bots/table_component.html.erb	96.6%
app/components/bots/table_component.rb	100.0%
app/components/personal_access_tokens/table_component.html.erb	95.6%
app/components/personal_access_tokens/table_component.rb	100.0%
app/controllers/concerns/bot_actions.rb	97.4%
app/controllers/concerns/bot_personal_access_token_actions.rb	97.5%
app/controllers/groups/bots_controller.rb	100.0%
app/controllers/projects/bots_controller.rb	100.0%
app/views/groups/bots/_access_token_section.html.erb	100.0%
app/views/groups/bots/_bot_modal.html.erb	100.0%
app/views/groups/bots/_table.html.erb	100.0%
app/views/groups/bots/create.turbo_stream.erb	100.0%
app/views/groups/bots/index.html.erb	100.0%
app/views/groups/bots/personal_access_tokens/_generate_personal_access_token_modal.html.erb	100.0%
app/views/groups/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb	100.0%
app/views/groups/bots/personal_access_tokens/_table.html.erb	100.0%
app/views/groups/bots/personal_access_tokens/create.turbo_stream.erb	100.0%
app/views/groups/bots/personal_access_tokens/revoke.turbo_stream.erb	100.0%
app/views/profiles/personal_access_tokens/_table.html.erb	100.0%
app/views/projects/bots/_access_token_section.html.erb	100.0%
app/views/projects/bots/_bot_modal.html.erb	100.0%
app/views/projects/bots/_table.html.erb	100.0%
app/views/projects/bots/create.turbo_stream.erb	100.0%
app/views/projects/bots/index.html.erb	100.0%
app/views/projects/bots/personal_access_tokens/_generate_personal_access_token_modal.html.erb	100.0%
app/views/projects/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb	100.0%
app/views/projects/bots/personal_access_tokens/_table.html.erb	100.0%
app/views/projects/bots/personal_access_tokens/create.turbo_stream.erb	100.0%
app/views/projects/bots/personal_access_tokens/index.turbo_stream.erb	100.0%
app/views/projects/bots/personal_access_tokens/revoke.turbo_stream.erb	100.0%
app/views/workflow_executions/submissions/create.turbo_stream.erb	100.0%

---

Reported by octocov