Pathogen: Demo app and lookbook #851
Draft
+3,196
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
pathogen/demo
branch
from
13d15f2 to
bc497e0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
pathogen/demo
branch
from
ecfc0ea to
92a68a9
Compare
This comment has been minimized.
This comment has been minimized.
joshsadam
added
enhancement
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
pathogen/demo
branch
from
121295e to
a0ca940
Compare
This comment has been minimized.
This comment has been minimized.
…tailwind colour names
… and improve formatting
…otes in puma.rb for consistency
…otes in initializer files for consistency
…otes in lookbook.rb for consistency
…rmance optimization
…otes in test.rb for consistency
…otes in production.rb for consistency
…otes in application.rb for consistency
…r documentation clarity
…otes in boot.rb for consistency
…otes in environment.rb for consistency
…otes in importmap.rb for consistency
… improved consistency
…eral comment for performance
…otes in development.rb for consistency
…otes in Rakefile for consistency
Required changing setting the disabled hover state to the default color
joshsadam
force-pushed
the
pathogen/demo
branch
from
a0ca940 to
3f33e0d
Compare
Code Metrics Report
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR expands on the current Pathogen View Components library by add LookBook previews and embedded testing for each component. Testing was moved from the IRIDA-next root into the Pathogen demo.
Also, an updating tailwind configuration is being created to simplify the naming of colour in components. This is still a living document so changes will be made to it.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
embedded_gems/pathogenbin/setupbin/devPR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.