Sidebar enhancements #861
Merged
Sidebar enhancements #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play - Consolidated class attributes in sidebar and header components for cleaner HTML. - Removed unused attributes and streamlined initialization in SidebarComponent and HeaderComponent. - Introduced item display in HeaderComponent to show relevant context. - Updated sidebar rendering in various layout files to utilize new header structure.
- Improved indentation and formatting for better readability. - Ensured consistent structure in the header component for enhanced maintainability.
…ency - Changed text color classes from 'text-gray' to 'text-slate' for better visual coherence. - Ensured consistent styling for item names in the sidebar header component.
…re and styling - Updated header element from <p> to <h2> for better semantic structure. - Adjusted spacing and alignment for item display to enhance visual clarity. - Changed item name display from <p> to <span> for consistency in styling.
- Deleted the LabelComponent class as it is no longer needed in the sidebar structure.
…ved header rendering - Enhanced the sidebar component's HTML structure for better readability and maintainability. - Updated the sidebar header to use a turbo frame for dynamic content rendering. - Modified turbo stream updates in group and project views to render the new sidebar header component with appropriate labels. - Ensured consistent styling and structure across sidebar elements.
…ing keys - Replaced single quotes with double quotes for consistency across various strings in the fr.yml locale file. - Ensured uniformity in error messages and labels to enhance readability and maintainability. - Updated multiple instances where text formatting was inconsistent, improving overall localization quality.
…ench locale with new keys - Replaced single quotes with double quotes for consistency across various strings in the en.yml locale file. - Updated error messages and labels to enhance readability and maintainability. - Added missing keys in the fr.yml locale file to improve localization coverage. - Ensured uniformity in text formatting across both locale files for better localization quality.
…rameters - Updated tests for LayoutComponent and SidebarComponent to remove redundant label and icon_name parameters. - Enhanced readability of test cases by focusing on essential rendering functionality. - Ensured consistency in sidebar header rendering across different test scenarios.
- Changed test selectors in GroupsTest and ProjectsTest from '#sidebar' and '#sidebar_project_name' to 'aside#sidebar' for better specificity. - Enhanced the readability and maintainability of the test cases by using more descriptive selectors.
… experience - Updated button classes in the sidebar component to enhance visual feedback with transition effects. - Changed background color for improved contrast and accessibility. - Ensured consistency in styling across different themes (light and dark).
This comment has been minimized.
This comment has been minimized.
joshsadam
added
enhancement
… on small screen size.
Code Metrics Report
Code coverage of files in pull request scope (100.0%)Reported by octocov |
ericenns
approved these changes
Dec 9, 2024
deepsidhu85
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
Go tothat allows a user to go the main IRIDA categories.Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Projects Page
Before
After
Project Page
Before
After
Group Page
Before
After
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.