Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Split projects/samples_test #865

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Dec 11, 2024

What does this PR do and why?

This PR splits the projects/samples_test, separating out all the show actions (attachments, metadata, and history) into their own respective files in order for the testing suite to me more managable.

Note: The fixes/refactor to these tests will handled in future PRs. This is PR simply to split the file.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Verify tests pass locally.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ChrisHuynh333 ChrisHuynh333 marked this pull request as ready for review December 11, 2024 16:37
@ChrisHuynh333 ChrisHuynh333 self-assigned this Dec 11, 2024
@ChrisHuynh333 ChrisHuynh333 added the ready for review Pull request is ready for review label Dec 11, 2024

This comment has been minimized.

@ChrisHuynh333 ChrisHuynh333 force-pushed the split-projects-samples-tests branch from ae30b2b to ef0b5e9 Compare December 11, 2024 22:00

This comment has been minimized.

Copy link

Code Metrics Report

Coverage Test Execution Time
92.7% 9m32s

Reported by octocov

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I compared the number of tests ran via bin/rails test test/system/projects/samples* on main and this branch and both had the same number of tests (110) and both succeeded.

@ericenns ericenns merged commit 60a6df4 into main Dec 12, 2024
4 checks passed
@ericenns ericenns deleted the split-projects-samples-tests branch December 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants