-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Sample::Query form object #866
Conversation
…the samples table component to no longer have a dependency on ransack
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work awesomely!
…t and group consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, everything functions as expected!
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (98.8%)Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Everything appears to be functioning as expected
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR refactors the Samples table to use ActiveModel to create a better search form for the Samples table, following this guide.
This PR removes initial implementation of metadata searching as that will be reimplemented using SearchKick.
This is a prerequisite for changing to SearchKick.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.