Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Sample::Query form object #866

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Feat: Sample::Query form object #866

merged 7 commits into from
Dec 11, 2024

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Dec 11, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR refactors the Samples table to use ActiveModel to create a better search form for the Samples table, following this guide.

This PR removes initial implementation of metadata searching as that will be reimplemented using SearchKick.

This is a prerequisite for changing to SearchKick.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Launch server
  2. Interact with Project and Groups Samples tables and ensure everything works as expected. The system tests should catch all cases.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

…the samples table component to no longer have a dependency on ransack
@ericenns ericenns self-assigned this Dec 11, 2024
@ericenns ericenns changed the title Feat: Sample Query Model Feat: Sample::Query form object Dec 11, 2024

This comment has been minimized.

joshsadam
joshsadam previously approved these changes Dec 11, 2024
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work awesomely!

Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, everything functions as expected!

This comment has been minimized.

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Everything appears to be functioning as expected

@deepsidhu85 deepsidhu85 merged commit eb9f41a into main Dec 11, 2024
4 checks passed
@deepsidhu85 deepsidhu85 deleted the sample_query_model branch December 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants