Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searchkick mappings for metadata #870

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Dec 13, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

Add in mappings section to SearchKick config for Samples which fixes issues with mapping types for metadata fields.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

… in _date as date and other fields as both text and numeric
@ericenns ericenns self-assigned this Dec 13, 2024
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to have fixed the issue, thanks!

Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end!

Copy link

Code Metrics Report

Coverage Test Execution Time
92.6% 9m51s

Code coverage of files in pull request scope (94.3%)

Files Coverage
app/models/sample.rb 94.3%

Reported by octocov

@joshsadam joshsadam merged commit 9da7f6c into main Dec 13, 2024
4 checks passed
@joshsadam joshsadam deleted the searchkick-metadata-indexing-fix branch December 13, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants