-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextflow Samplesheet: File Selector #879
Conversation
012975c
to
6f9cc82
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
app/views/workflow_executions/file_selector/_file_selector_dialog.html.erb
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
cbb7f96
to
26efb01
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few issues while testing this out.
- No way of seeing if a file is single ended or pair end. (Maybe we need to add
format
andtype
columns) - If I select a single end file for
fastq_1
it does not set the input forfastq_2
to none which was the previous behaviour
Thanks for catching these. I've updated with associated test in 8179e7d |
This comment has been minimized.
This comment has been minimized.
4d9c5a8
to
1863c8c
Compare
This comment has been minimized.
This comment has been minimized.
…ed asserts for flakes
…logic, make radio buttons sticky for horizontal scrolling
…f original selector
…te fastq_2 to no file
1863c8c
to
bb784ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What does this PR do and why?
This PR is for issue
STRY0016505
, which requested the nextflow samplesheet be populated with the most recent uploaded file, and to add the uploaded time of each file to its respective listing.Having filename + created date within the original dropdown selection looked very cumbersome and so, for a better user experience, we decided to create a file selector so more file data could be displayed to the user.
Screenshots or screen recordings
Samplesheet (attachments selection no longer a dropdown)
File Selector:
How to set up and validate locally
Test selecting paired-end files:
fastq_1
orfastq_2
fields, click the file to open the file selector.fastq_#
field,Test selecting single-end files, default paired-end selection and
No file
selection:fastq_1
field, and verify all the uploaded attachments are included, and that there is noNo file
option (sincefastq_1
is required).fastq_1
field updates with the selection andfastq_2
changed toNo File
.fastq_2
field, and verify none of the uploaded attachments are included, and that there is aNo file
option.fastq_1
contains the selected attachment andfastq_2
contains no attachment)Test samplesheet validation of selected files and file selector empty state:
fastq_1
andfastq_2
attachment fields have no file selected.fastq_1
field is highlighted in red, asfastq_2
is not required.fastq_1
orfastq_2
file field. Verify ano attachments
message within the file selector, with no submit button.Test file selector filtering:
1 Selected a seeded sample and launch a workflow (any version)
2. Click either the
fastq_1
orfastq_2
attachment fields.3. Verify
reference.fasta
is not displayed as it's not afastq
file.PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.