Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Execution logidze #890

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Workflow Execution logidze #890

merged 9 commits into from
Jan 10, 2025

Conversation

deepsidhu85
Copy link
Contributor

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR updates the workflow_executions table to include a jsonb log_data column used to log changes to a workflow execution.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Launch a new workflow execution
  2. In the rails console, set this workflow execution to a variable and then do a .reload_log_data to see the logged changes as the workflow execution progress through steps
  3. Launch another workflow execution and cancel it right away
  4. In the rails console, view this workflow execution, and then do a .reload_log_data on it. Should have 2 entries (one for creating and one for the cancelation which should only have the state logged)

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@deepsidhu85 deepsidhu85 requested a review from ericenns January 8, 2025 21:07
@deepsidhu85 deepsidhu85 self-assigned this Jan 8, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@deepsidhu85 deepsidhu85 force-pushed the add-logidze-workflow-executions branch from 72a8bbb to 894445e Compare January 10, 2025 16:27

This comment has been minimized.

Copy link

Code Metrics Report

Coverage Test Execution Time
92.9% 10m20s

Reported by octocov

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit 9c15cbf into main Jan 10, 2025
4 checks passed
@ericenns ericenns deleted the add-logidze-workflow-executions branch January 10, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants