Workflow Executions: Share results #895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malchua
force-pushed
the
workflow_execution/share_results
branch
from
2d4b702 to
0115044
Compare
This comment has been minimized.
This comment has been minimized.
malchua
force-pushed
the
workflow_execution/share_results
branch
from
93d1b1a to
493bce6
Compare
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (98.8%)Reported by octocov |
There was a problem hiding this comment.
Some comments below to start and also some clarification questions (maybe geared more towards @ericenns :
- I would think we need a Workflow Execution listing for groups now? I don't see anywhere to view a workflow that's been shared with the group
- Should the user that created a shared workflow still be able to cancel/delete/modify the workflow from their own personal workflow listing?
- Listing the user that created the shared workflow on the workflow summary tab?
Also, could the description header for the project workflow executions page be updated as it no longer pertains to only automated workflows:
Comment on lines
+118
to
+131
| class: | ||
| "w-4 | ||
| h-4 | ||
| mr-2.5 | ||
| text-primary-600 | ||
| bg-slate-100 | ||
| border-slate-300 | ||
| rounded | ||
| focus:ring-primary-500 | ||
| dark:focus:ring-primary-600 | ||
| dark:ring-offset-slate-800 | ||
| focus:ring-2 | ||
| dark:bg-slate-700 | ||
| dark:border-slate-600", |
There was a problem hiding this comment.
Can you move these onto a single line. We've been moving class lists like these to a single line to prevent this endless 'tabbing' of the classes.
| @@ -3,7 +3,7 @@ | |||
| require 'application_system_test_case' | |||
There was a problem hiding this comment.
Can you add a UI test verifying the expected absence of the shared workflow row actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR relates to STRY0016470, where we want to be able to share our workflow execution results to the project/group so that members are able to see the results. This PR covers issue #884
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.