Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 2 Compatibility #193

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Pandas 2 Compatibility #193

merged 3 commits into from
Aug 15, 2023

Conversation

emarinier
Copy link
Member

Addresses: #184

@emarinier emarinier self-assigned this Aug 11, 2023
@emarinier emarinier requested a review from apetkau August 11, 2023 16:22
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much. This looks great. A few comments:

  1. Can you change the GitHub Actions file so that:
    1. The restriction on the pandas version no longer exists (also remove the restriction on the numpy version, since I forget why it's there, so we'll see if the tests still all work).
      other-packages: "mlst 'numpy <1.23.5' 'pandas <2'"
    2. Update the integration tests to work with Python 3.11 (latest). We could have both 3.7 and 3.11, but I think just testing on one Python version is okay.
      - python-version: "3.7"
  2. Add an entry to the CHANGELOG.md on this change.

@emarinier
Copy link
Member Author

I updated the GitHub workflow, as you recommended, but I also had to add perl-list-moreutils as a conda dependency.

I think we'll also have to make similar changes to the instructions to install development / release versions at some point too.

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these changes. This looks great :)

@apetkau apetkau merged commit 387dbcd into development Aug 15, 2023
1 check passed
@apetkau apetkau deleted the dev/pandas2 branch August 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants