Us2 admin projects #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has done part of it, but method: PUT and method: DELETE still not working, and tried but do not find out the problems
pharapeti
requested changes
May 18, 2021
| headers: { 'Content-Type': 'application/json', | ||
| 'Accept': 'application/json', | ||
| 'Access-Control-Allow-Origin': "*", | ||
| 'Access-Control-Allow-Methods': "PUT"}, |
There was a problem hiding this comment.
This backend route does not exist, you currently cannot update a project via the front end
| @@ -30,7 +30,7 @@ class UrlSet extends Component{ | |||
| <Route path="/student/projects/:project_id/groups/:group_id" exact strict component={StudentGroup}/> | |||
| <Route path="/admin/home" exact strict component={AdminMainMenu}/> | |||
| <Route path="/admin/notifications" exact strict component={AdminNotification}/> | |||
| <Route path="/admin/projects/new" exact strict component={AdminCreateProject}/> | |||
| <Route path="/admin/projects/create/new" exact strict component={AdminCreateProject}/> | |||
There was a problem hiding this comment.
this is not a restful route https://restfulapi.net/resource-naming/
There was a problem hiding this comment.
I know, but the question is that since we set the project route : /admin/projects/:project_id
the previous route: /admin/projects/new many make project_id = new, which may cause problems.
So how to fix it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change doing?
finish fetching data from projects, projects-allocations
Why is it needed?
main function of US2
Where should the reviewer start?
just start by opening in broswer
How can these changes be manually tested?
just review the code
What user story does this PR relate to? (include link)
US2
Screenshots (if applicable)
mostly done, but still have two problems in admin/projects and admin/editprojects, like when when using 'method: 'PUT'' and 'method: 'DELETE'', this may not fetch data successful, here is:
I dont know how to fix it, the rest is all OK.