Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superseded deprecated function #36

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

athenamelia
Copy link
Collaborator

PR for superseded functions

Copy link

github-actions bot commented Jan 19, 2024

Unit Tests Summary

1 files  1 suites   15s ⏱️
3 tests 3 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 80a098c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 19, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
discovery 💚 $24.34$ $-9.28$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
discovery 💚 $22.45$ $-9.37$ Check_Valid_URLs
discovery 💀 $1.45$ $-1.45$ Warn_for_Deprecated_Supersded_Functions
discovery 👶 $+1.50$ Warn_for_Deprecated_Superseded_Functions

Results for commit ada4599

♻️ This comment has been updated with latest results.

@athenamelia
Copy link
Collaborator Author

  • Amelia removed superseded functions and replaced them with new functions. In particular:
  • derive_var_extreme_dt() replaced by derive_vars_extreme_event()
  • get_summary_records() replaced by derive_summary_records()
  • derive_param_response() replaced by derive_extreme_event()

Closes #34

@ddsjoberg ddsjoberg self-requested a review January 19, 2024 21:55
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athenamelia thanks for the PR! I have two questions/comments

  1. Since you added your middle initial in the DESCRIPTION file, you'll need to redocument the package and push the updated files. devtools::document()
  2. Can you explain why this line was omitted and not replaced with anything?
    image

@athenamelia
Copy link
Collaborator Author

@ddsjoberg thanks for the feedbacks! I ran devtools::document() and updated the csv file with the row for "LSTA: Last Disease Assessment by Investigator" variable.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ddsjoberg ddsjoberg merged commit b172b88 into main Jan 19, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the superseded_deprecated_function branch January 19, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants