Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #181 Assertion added for cut date not to be NULL #181 #197

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

barnett11
Copy link
Collaborator

@barnett11 barnett11 commented Jan 26, 2024

Thank you for your Pull Request! admiraldev have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the datacutr codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build datacutr site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Jan 26, 2024

Code Coverage

Package Line Rate Health
datacutr 100%
Summary 100% (389 / 389)

@barnett11
Copy link
Collaborator Author

There is a pull request warning for updating roxygen2. I am struggling to do it, and given it is not important and has other knock on impacts, we will ignore for this release and investigate post release (as it does not impact the package directlty)

@alanaharris22 alanaharris22 merged commit 70f4f67 into devel Feb 9, 2024
14 of 15 checks passed
@alanaharris22
Copy link
Collaborator

Thanks Tim, looks good.

@barnett11 barnett11 deleted the 181_nullcut branch February 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: More verbose/detailed error message when cut_date is fed into create_dcut incorrectly
2 participants