Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #188 Update process_cut to use NULL as the default for empty input arguments #201

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

reesnj
Copy link
Collaborator

@reesnj reesnj commented Mar 5, 2024

Thank you for your Pull Request! admiraldev have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the datacutr codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build datacutr site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@reesnj reesnj requested a review from barnett11 March 5, 2024 18:37
@reesnj reesnj self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Code Coverage

Package Line Rate Health
datacutr 100%
Summary 100% (404 / 405)

@reesnj
Copy link
Collaborator Author

reesnj commented Mar 14, 2024

Hello @barnett11 - this pull request now closes issue #180 and #188. Please review when you have a moment.

Copy link
Collaborator

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reesnj - the null setting is working fine thanks. For the messaging on mis-matched domains, this doesn't work so well if there is more than one domain mis-matching. We may need an alternative approach, i see this happening a lot with SDTM where we have so many

@reesnj
Copy link
Collaborator Author

reesnj commented Apr 3, 2024

Hi @reesnj - the null setting is working fine thanks. For the messaging on mis-matched domains, this doesn't work so well if there is more than one domain mis-matching. We may need an alternative approach, i see this happening a lot with SDTM where we have so many

Thanks @barnett11 - this issue has now been resolved.

@barnett11 barnett11 self-requested a review April 26, 2024 13:48
Copy link
Collaborator

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reesnj - looking really good - have tested various scenarios and does what we need it to. I saw an issue appear for styler, do we want to update for it? Is there a reason not to?

@reesnj
Copy link
Collaborator Author

reesnj commented Jun 5, 2024

Hello @barnett11 - are you happy for me to merge this into devel?

Copy link
Collaborator

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reesnj - yes all looking good now thnak you

@reesnj reesnj merged commit 290d205 into devel Jun 7, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update process_cut to use NULL as the default for empty input arguments
2 participants