Merge devel into main for v0.2 #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PR template as per admiral #192
…cutdtc 189 impute dcutdtc missing dcutdtc
…andling-missing-datacut-date 190 update create dcut for handling missing datacut date
…v arguments have a default value of NULL
Closes #188 Update process_cut to use NULL as the default for empty input arguments
* exploratory programs for read-out files * markdown practice * changes to markdown table layout * basic Rmarkdown file produced & exploratory scripts * draft completion of Read-out file version 1 * format complete of .Rmd for datacutr read-out file, modified process_cut() to enable auto-generation * changed .Rmd file location and combined custom functions within the markdown * read_out function added, exploratory work on updating functions within read_out_2.Rmd * remove .Rmd test scripts * update to the .Rmd text * draft testing files for read_out() function with minor updates to .Rmd * updates made to .Rmd file and function with testing * updates to the read_out() function along with modifications to the .Rmd messages * development of read_out() function and testing continued. * updates to process_cut() and read_out() functions, completion of test-read_out.R * remove excess .Rmd files * remove final_cut argument and section in .Rmd, update file path read_out() * Update read_out.Rmd with reactables package instead of datatables to allow for larger data inputs. * removed old datacutr read-out file .Rmd * Changes made to the documentation for read-out * update renv.lock files for R4.3.1 * resolving warnings in pull request checks * updates to resolve check errors * updates to read_out.Rmd & read_out.R to address feedback * update to renv.lock file CRAN version * updates to renv file, removed unused packages * revert renv.lock file * updates to renv.lock - include "admiraldev", upgrade "remotes" * update remotes version * troubleshooting - test * update stringi repo to "CRAN" * add author * updates to the read_out function and read_out.Rmd * updated the renv.lock for datacutr R4.3.1 * update the .Rprofile * add library(tibble) to read_out.Rmd * update R version in DESCRIPTION, remove lintr complexity check from process_cut.R * update to R version DESCRIPTION, common.yml & no lint process_cut.R * updates to resolve styler errors * resolve CICD check errors * resolve styler and roxygen2 errors * update the NEWS.md to reflect update in R version
* Add devel to cicd trigger * Undo spelling fix
* fix: No renv * chore: Ignore indentation linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! admiraldev have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the datacutr codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
develbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()