Skip to content

Commit

Permalink
Merge pull request #76 from pharmaverse/75_addressing_cran_sumission_…
Browse files Browse the repository at this point in the history
…issues

closes #75 Addressing CRAN feedback by updating the link
  • Loading branch information
sadchla-codes authored Jun 29, 2024
2 parents 1953c1b + fbd8b9e commit 8fe042a
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 6 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@
^CRAN-SUBMISSION$
^data-raw
^tmp
^cran-comments\.md$
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Please check off each taskbox as an acknowledgment that you completed the task o
- [ ] Run `devtools::document()` so all `.Rd` files in the `man` folder and the `NAMESPACE` file in the project root are updated appropriately
- [ ] Address any updates needed for vignettes and/or templates
- [ ] Update `NEWS.md` if the changes pertain to a user-facing function (i.e. it has an `@export` tag) or documentation aimed at users (rather than developers)
- [ ] Build admiral site `pkgdown::build_site()` and check that all affected examples are displayed correctly and that all new functions occur on the "[Reference](https://pharmaverse.github.io/admiral/reference/index.html)" page.
- [ ] Build pharmaverseadam site `pkgdown::build_site()` and check that all affected examples are displayed correctly and that all new datasets occur on the "[Reference](https://pharmaverse.github.io/pharmaverseadam/reference/index.html)" page.
- [ ] Address or fix all lintr warnings and errors - `lintr::lint_package()`
- [ ] Run `R CMD check` locally and address all errors and warnings - `devtools::check()`
- [ ] Link the issue in the Development Section on the right hand side.
Expand Down
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.2.0
Date: 2024-01-05 12:23:42 UTC
SHA: 22afe47ad4a8516ea36e83be863c52e6c4a544d6
Version: 1.0.0
Date: 2024-06-28 04:17:56 UTC
SHA: 1953c1ba395ce9530440a08849fde695a27e2a70
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Description: A set of Analysis Data Model (ADaM) datasets constructed using the
described in: CDISC Analysis Data Model Team
(2021) <https://www.cdisc.org/system/files/members/standard/foundational/ADaMIG_v1.3.pdf>.
License: Apache License (>= 2)
URL: https://pharmaverse.github.io/pharmaverseadam/main/, https://github.com/pharmaverse/pharmaverseadam/
URL: https://pharmaverse.github.io/pharmaverseadam, https://github.com/pharmaverse/pharmaverseadam/
Encoding: UTF-8
Language: en-US
LazyData: true
Expand Down
5 changes: 5 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## R CMD check results

0 errors | 0 warnings | 1 note

* This is a new release.
1 change: 1 addition & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ PPROTFL
PPSRFL
Pharmacodynamic
Pharmacokinetic
pharamverseadam
Pharmaverse
Prd
Pre
Expand Down
2 changes: 1 addition & 1 deletion man/pharmaverseadam-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8fe042a

Please sign in to comment.