Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun ADaM templates #61

Merged
merged 14 commits into from
Jun 6, 2024
Merged

rerun ADaM templates #61

merged 14 commits into from
Jun 6, 2024

Conversation

kaz462
Copy link
Contributor

@kaz462 kaz462 commented Apr 17, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@kaz462
Copy link
Contributor Author

kaz462 commented Apr 17, 2024

Hi @shajoezhu, not able to add you as a reviewer, but please check if the updated data meets your needs from
#57 Thank you!

NEWS.md Outdated Show resolved Hide resolved
@dgrassellyb dgrassellyb self-requested a review April 24, 2024 15:19
@manciniedoardo
Copy link
Collaborator

Update from 2024-05-16 meeting: we will do a re run on 31st May and then merge, unless meeting with NEST team next week results in further requests for changes.

@kaz462 kaz462 requested a review from sadchla-codes May 29, 2024 04:20
R/adae.R Outdated Show resolved Hide resolved
R/adrs_onco.R Outdated Show resolved Hide resolved
R/adtr_onco.R Outdated Show resolved Hide resolved
Copy link
Contributor

@sadchla-codes sadchla-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@shajoezhu
Copy link

hey guys, we have checked and everything looks in order. I think this is ready to be merged. Thanks so much! @kaz462 @manciniedoardo

@manciniedoardo manciniedoardo merged commit ba77c7a into main Jun 6, 2024
16 checks passed
@manciniedoardo manciniedoardo deleted the adpp_adpc_update branch June 6, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants