Deprecate #newMethod:header: with rewritting to #basicNew:header: #16375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 11:45
The direct call to the primitive is removed, because otherwise as long as it works the deprecation will never be applied. The deprecated methods now rewrites the call site and then call the new version of the method.
|
Now is failing. There is pharo-spec/ScriptableDebugger#87 which has to be fixed first |
|
I did a PR: pharo-spec/ScriptableDebugger#91 |
|
I merge the PR 90, close and re-open to rum the tests in a newly build image |
|
The PR I merged was against the master branch, we should have one for the Pharo12 branch instead. I re-opened pharo-spec/ScriptableDebugger#91, which is the same but for Pharo12 branch |
jecisc
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15625.