Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider #1619

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Fix slider #1619

merged 3 commits into from
Oct 13, 2024

Commits on Oct 7, 2024

  1. Fixes in slider's Morphic adapter 

    - Value: presenter and widget were not syncing correctly
- Horizontal slider didn't work except when min=0 and max=1.
- Vertical slider was wrong (not it becomes an ignored presenter property)
- Value was supporting (unexpectedly) parsing from string, with special adhoc support for fractions
- Label didn't update when change after opened
    @tinchodias
    tinchodias committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d9f708b View commit details
    Browse the repository at this point in the history

  2. Fixes on test case for slider's adapter 

    - Rename SpSliderPresenterBackendTest -> SpSliderAdapterTest
- Add tests (only 2 smoke tests before)
    @tinchodias
    tinchodias committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cc09458 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Delete color: override from slider presenter. 

    - This kind of visual property needs to be defined through styles.
- It does not work (self does not understand #widget), so there are no users
    @tinchodias
    tinchodias committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5134345 View commit details
    Browse the repository at this point in the history