This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
starshot_admin_theme needs to import Claro's configuration to avoid missing blocks if the site switches to it #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenaproxima
reviewed
Aug 2, 2024
| - block.block.claro_messages | ||
| - block.block.claro_page_title | ||
| - block.block.claro_primary_local_tasks | ||
| - block.block.claro_secondary_local_tasks |
There was a problem hiding this comment.
Is there any reason to list these blocks explicitly, and not just do claro: '*'?
I'm okay with either way, but would like there to be an explanatory comment here if we're not going to use *.
phenaproxima
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.