This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Add test coverage to prove that the installer actually applies the Starshot recipe #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenaproxima
force-pushed
the
fix-regression
branch
4 times, most recently
from
e837679
to
efa1fce
Compare
phenaproxima
force-pushed
the
fix-regression
branch
2 times, most recently
from
2398445
to
158bb2d
Compare
phenaproxima
changed the title
phenaproxima
force-pushed
the
fix-regression
branch
from
158bb2d
to
e658c4a
Compare
phenaproxima
force-pushed
the
fix-regression
branch
from
e658c4a
to
9d2f37b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the choice of site template into
RecipesForm, and submitting it without a default value supplied insubmitForm(), might have broken installation via Drush in some situations. It doesn't seem to be happening consistently, but I think it's worth having test coverage about this.