PC-77 Improvements to sign up & review process. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antonkatz
commented
Nov 13, 2015
antonkatz
commented
- All admins listed in SignUpAdmins group should receive all new pending sign up requests.
- Upon approval, confirmation e-mail should be sent to the user.
- Upon request rejection an email needs to be sent to the user.
1. All admins listed in SignUpAdmins group should receive all new pending sign up requests. 2. Upon approval, confirmation e-mail should be sent to the user. 3. Upon request rejection an email needs to be sent to the user.
| "userRealName": $realName.trim(), | ||
| "userName": $userDoc.name, | ||
| "adminName": $mainAdminName, | ||
| "adminEmail": $mainAdminEmail, | ||
| "platformName": "PhenomeCentral", |
There was a problem hiding this comment.
Why do we include platformName as a variable in the email template, if we use "PhenomeCentral" without referencing the variable?
There was a problem hiding this comment.
That's how it's been. Plus, if it ever changes, we don't have to edit the template.
| @@ -130,12 +191,44 @@ The ${platformName} team</p></html> | |||
| <subject>Your account at PhenomeCentral has been approved</subject> | |||
There was a problem hiding this comment.
Can we use platformName here as well?
There was a problem hiding this comment.
Interesting question. My gut tells me no, though.
|
Valid PR, needs final review. |
| <p>Best wishes,<br> | ||
| The ${platformName} team</p></html> | ||
| <html><p>Dear ${userRealName},</p> | ||
| <p>An account has been created for you on ${platformName}. If you forgot your password, please visit <a href="https://phenomecentral.org/XWiki/ResetPassword">https://phenomecentral.org/XWiki/ResetPassword</a> and enter your username ${userName}. Please do not hesitate to contact us if you experience any difficulties with your account.</p> |
There was a problem hiding this comment.
Any URL pointing to phenomecentral.org should be parametrized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.