fix order of guess and answer lines for point tools, #89

phetsims · Feb 5, 2019 · 223b18a · 223b18a · pixelzoom · Feb 5, 2019
1 parent 0d948a7
commit 223b18a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/js/linegame/model/GraphTheLine.js b/js/linegame/model/GraphTheLine.js
@@ -59,22 +59,22 @@ define( function( require ) {
 
     /**
      * Updates the collection of lines that are 'seen' by the point tools.
+     * Order is important here! See https://github.com/phetsims/graphing-lines/issues/89
      * @override
      * @protected
      */
     updateGraphLines: function() {
 
       this.graph.lines.clear();
 
-      // Add lines in the order that they would be rendered.
+      if ( this.answerVisible ) {
+        this.graph.lines.push( this.answer );
+      }
+
       // Account for guesses that might be NotALine (not a valid line).
       if ( this.guessProperty.get() instanceof Line ) {
         this.graph.lines.push( this.guessProperty.get() );
       }
-
-      if ( this.answerVisible ) {
-        this.graph.lines.push( this.answer );
-      }
     }
   } );
 } );
diff --git a/js/linegame/model/MakeTheEquation.js b/js/linegame/model/MakeTheEquation.js
@@ -58,16 +58,16 @@ define( function( require ) {
 
     /**
      * Updates the collection of lines that are 'seen' by the point tools.
+     * Order is important here! See https://github.com/phetsims/graphing-lines/issues/89
      * @override
      * @protected
      */
     updateGraphLines: function() {
       this.graph.lines.clear();
-      // add lines in the order that they would be rendered
+      this.graph.lines.push( this.answer );
       if ( this.answerVisible ) {
         this.graph.lines.push( this.guessProperty.get() );
       }
-      this.graph.lines.push( this.answer );
     }
   } );
 } );