Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color in point tool turns black when problem is solved #112

Closed
KatieWoe opened this issue Feb 4, 2019 · 8 comments
Closed

Color in point tool turns black when problem is solved #112

KatieWoe opened this issue Feb 4, 2019 · 8 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 4, 2019

For phetsims/qa#277 and phetsims/qa#278
May be connected to #89. Did not appear in published version of graphing lines.

When you use the point tool on the green line in a game level the color of the point tool turns green. However, when you have solved that problem, the color turns black. It does not seem to happen if you answered incorrectly.
turnsblack

@pixelzoom
Copy link
Contributor

@KatieWoe I'm not able to reproduce this. It might be specific to certain types of challenges, and the screenshot above is cropped. Can you please provide move specific steps (level) and screenshots of the challenge before and after solving it? Thanks.

@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Feb 4, 2019
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 4, 2019

I saw on any challenge that had a green set line (I was on level one). The ones with a black line had a similar problem where they turned green when solved, but the pointer tool didn't change. Here are two examples, before and after being solved. I was on Win 10 chrome.
yes1
yessolve1
yes4
yessolve4
I also noticed in this last picture that the green line cuts over the black dot. Is that intended?

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 4, 2019

Just reproduced on Mac 10.14 safari.

@pixelzoom
Copy link
Contributor

@KatieWoe said:

I also noticed in this last picture that the green line cuts over the black dot. Is that intended?

No, not intended. Lines should be behind points and manipulators.

@pixelzoom
Copy link
Contributor

Fixed in the above commit. @KatieWoe please verify in master. If it looks OK, please leave this issue open to regression test in the next RC.

@pixelzoom pixelzoom removed their assignment Feb 5, 2019
pixelzoom added a commit that referenced this issue Feb 5, 2019
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 5, 2019

Looks good on master

@pixelzoom
Copy link
Contributor

Pending regression testing in 1.3.0-rc.2.

@KatieWoe
Copy link
Contributor Author

Confirmed in both rcs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants