comment out createKeyboardHelpNode in all screens, to prevent PhET-iO…

… memory leak, #249
phetsims · Nov 17, 2022 · cd9a7e5 · cd9a7e5
1 parent 7ed6b11
commit cd9a7e5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/js/macro/MacroScreen.ts b/js/macro/MacroScreen.ts
@@ -20,7 +20,6 @@ import phScale from '../phScale.js';
 import PhScaleStrings from '../PhScaleStrings.js';
 import MacroModel from './model/MacroModel.js';
 import MacroScreenView from './view/MacroScreenView.js';
-import MacroKeyboardHelpContent from './view/MacroKeyboardHelpContent.js';
 
 type SelfOptions = EmptySelfOptions;
 
@@ -42,8 +41,9 @@ export default class MacroScreen extends Screen<MacroModel, MacroScreenView> {
       navigationBarIcon: new ScreenIcon( new Image( macroNavbarIcon_png ), {
         maxIconWidthProportion: 1,
         maxIconHeightProportion: 1
-      } ),
-      createKeyboardHelpNode: () => new MacroKeyboardHelpContent()
+      } )
+      //TODO https://github.com/phetsims/ph-scale/issues/249 restore when work on alternative input resume
+      // createKeyboardHelpNode: () => new MacroKeyboardHelpContent()
     }, providedOptions );
 
     super(

diff --git a/js/micro/MicroScreen.ts b/js/micro/MicroScreen.ts
@@ -20,7 +20,6 @@ import PhScaleStrings from '../PhScaleStrings.js';
 import MicroModel from './model/MicroModel.js';
 import MicroScreenView from './view/MicroScreenView.js';
 import PickRequired from '../../../phet-core/js/types/PickRequired.js';
-import MicroKeyboardHelpContent from './view/MicroKeyboardHelpContent.js';
 
 type SelfOptions = EmptySelfOptions;
 
@@ -42,8 +41,9 @@ class MicroScreen extends Screen<MicroModel, MicroScreenView> {
       navigationBarIcon: new ScreenIcon( new Image( microNavbarIcon_png ), {
         maxIconWidthProportion: 1,
         maxIconHeightProportion: 1
-      } ),
-      createKeyboardHelpNode: () => new MicroKeyboardHelpContent()
+      } )
+      //TODO https://github.com/phetsims/ph-scale/issues/249 restore when work on alternative input resume
+      // createKeyboardHelpNode: () => new MicroKeyboardHelpContent()
     }, providedOptions );
 
     super(

diff --git a/js/mysolution/MySolutionScreen.ts b/js/mysolution/MySolutionScreen.ts
@@ -19,7 +19,6 @@ import PHScaleColors from '../common/PHScaleColors.js';
 import phScale from '../phScale.js';
 import PhScaleStrings from '../PhScaleStrings.js';
 import MySolutionModel from './model/MySolutionModel.js';
-import MySolutionKeyboardHelpContent from './view/MySolutionKeyboardHelpContent.js';
 import MySolutionScreenView from './view/MySolutionScreenView.js';
 
 type SelfOptions = EmptySelfOptions;
@@ -42,8 +41,9 @@ export default class MySolutionScreen extends Screen<MySolutionModel, MySolution
       navigationBarIcon: new ScreenIcon( new Image( mySolutionNavbarIcon_png ), {
         maxIconWidthProportion: 1,
         maxIconHeightProportion: 1
-      } ),
-      createKeyboardHelpNode: () => new MySolutionKeyboardHelpContent()
+      } )
+      //TODO https://github.com/phetsims/ph-scale/issues/249 restore when work on alternative input resume
+      // createKeyboardHelpNode: () => new MySolutionKeyboardHelpContent()
     }, providedOptions );
 
     super(