Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Testing: broken locales and Safari text #1052

Closed
jonathanolson opened this issue Mar 1, 2024 · 9 comments
Closed

Maintenance Testing: broken locales and Safari text #1052

jonathanolson opened this issue Mar 1, 2024 · 9 comments

Comments

@jonathanolson
Copy link
Contributor

This is a continuation of #1039.

Primary fix was for #1036 / https://github.com/phetsims/website-meteor/issues/656, fixing the workaround for phetsims/collision-lab#177.

Secondary fix is for #1039 (comment), and some issues in phetsims/scenery#1610, and has been applied since that previous QA MR testing.

A tertiary fix is for https://github.com/phetsims/website-meteor/issues/656#issuecomment-1970206354, and was patched in babel. That affects live simulations (if they are rebuilt), so expedient testing on that would be helpful!

NOT FIXED: phetsims/joist#952
ONLY PARTIALLY WORKED AROUND: phetsims/scenery#1610

The secondary fix hits alls sims, and has a different code path for Safari and non-Safari, so I'd like each of those tested briefly with both of those browser types. Text issues will likely be fairly obvious, but some deeper spot checks in a few sims would be great.

I'll post checklists below, as discussed previously.

@jonathanolson
Copy link
Contributor Author

jonathanolson commented Mar 1, 2024

All-sim testing for the secondary fix:

acid-base-solutions 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

area-builder 1.1 (phetsims/scenery#1616)

area-model-algebra 1.2 (phetsims/scenery#1616)

area-model-decimals 1.2 (phetsims/scenery#1616)

area-model-introduction 1.2 (phetsims/scenery#1616)

area-model-multiplication 1.2 (phetsims/scenery#1616)

arithmetic 1.0 (phetsims/scenery#1616)

atomic-interactions 1.2 (phetsims/scenery#1616)

balancing-act 1.1 (phetsims/scenery#1616)

balancing-chemical-equations 1.2 (phetsims/scenery#1616)

balloons-and-static-electricity 1.3-phetio (phetsims/scenery#1616)

balloons-and-static-electricity 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

beers-law-lab 1.7 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

bending-light 1.1 (phetsims/scenery#1616)

blackbody-spectrum 1.0 (phetsims/scenery#1616)

build-a-fraction 1.0 (phetsims/scenery#1616)

build-a-molecule 1.0 (phetsims/scenery#1616)

build-a-nucleus 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

build-an-atom 1.5-phetio (phetsims/scenery#1616)

build-an-atom 1.6 (phetsims/scenery#1616)

calculus-grapher 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

capacitor-lab-basics 1.6 (phetsims/scenery#1616)

center-and-variability 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

charges-and-fields 1.0 (phetsims/scenery#1616)

charges-and-fields 1.0-phetio (phetsims/scenery#1616)

circuit-construction-kit-ac 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-ac-virtual-lab 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-dc 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-dc-virtual-lab 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

collision-lab 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

color-vision 1.1 (phetsims/scenery#1616)

color-vision 1.2-phetio (phetsims/scenery#1616)

concentration 1.5-phetio (phetsims/scenery#1616)

concentration 1.7 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

coulombs-law 1.0 (phetsims/scenery#1616)

curve-fitting 1.0 (phetsims/scenery#1616)

density 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

diffusion 1.0 (phetsims/scenery#1616)

energy-forms-and-changes 1.4 (phetsims/scenery#1616)

energy-skate-park 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

energy-skate-park-basics 1.1 (phetsims/scenery#1616)

energy-skate-park-basics 1.3-phetio (phetsims/scenery#1616)

equality-explorer 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

equality-explorer-basics 1.0 (phetsims/scenery#1616)

equality-explorer-two-variables 1.0 (phetsims/scenery#1616)

expression-exchange 1.1 (phetsims/scenery#1616)

faradays-law 1.3-phetio (phetsims/scenery#1616)

faradays-law 1.4 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

forces-and-motion-basics 2.1-phetio (phetsims/scenery#1616)

forces-and-motion-basics 2.2-phetio (phetsims/scenery#1616)

forces-and-motion-basics 2.3 (phetsims/scenery#1616)

forces-and-motion-basics 2.3-phetio (phetsims/scenery#1616)

fourier-making-waves 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

fraction-matcher 1.2 (phetsims/scenery#1616)

fractions-equality 1.1 (phetsims/scenery#1616)

fractions-intro 1.0 (phetsims/scenery#1616)

fractions-mixed-numbers 1.0 (phetsims/scenery#1616)

friction 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

function-builder 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

function-builder-basics 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gas-properties 1.0 (phetsims/scenery#1616)

gases-intro 1.0 (phetsims/scenery#1616)

gene-expression-essentials 1.0 (phetsims/scenery#1616)

geometric-optics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

geometric-optics-basics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

graphing-lines 1.3 (phetsims/scenery#1616)

graphing-quadratics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

graphing-slope-intercept 1.1 (phetsims/scenery#1616)

gravity-and-orbits 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gravity-and-orbits 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gravity-force-lab 2.2 (phetsims/scenery#1616)

gravity-force-lab-basics 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

greenhouse-effect 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

greenhouse-effect 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

hookes-law 1.0 (phetsims/scenery#1616)

isotopes-and-atomic-mass 1.1 (phetsims/scenery#1616)

john-travoltage 1.4-phetio (phetsims/scenery#1616)

john-travoltage 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

keplers-laws 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

least-squares-regression 1.1 (phetsims/scenery#1616)

make-a-ten 1.0 (phetsims/scenery#1616)

masses-and-springs 1.0 (phetsims/scenery#1616)

masses-and-springs-basics 1.0 (phetsims/scenery#1616)

mean-share-and-balance 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molarity 1.4 (phetsims/scenery#1616)

molarity 1.5 (phetsims/scenery#1616)

molecule-polarity 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecule-shapes 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecule-shapes-basics 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecules-and-light 1.3-phetio (phetsims/scenery#1616)

molecules-and-light 1.5 (phetsims/scenery#1616)

my-solar-system 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.2 (phetsims/scenery#1616)

natural-selection 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.4 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

neuron 1.1 (phetsims/scenery#1616)

normal-modes 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-compare 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-distance 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-integers 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-operations 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-play 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ohms-law 1.4 (phetsims/scenery#1616)

pendulum-lab 1.0 (phetsims/scenery#1616)

ph-scale 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ph-scale-basics 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ph-scale-basics 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

plinko-probability 1.1 (phetsims/scenery#1616)

projectile-motion 1.0 (phetsims/scenery#1616)

proportion-playground 1.0 (phetsims/scenery#1616)

quadrilateral 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ratio-and-proportion 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

reactants-products-and-leftovers 1.2 (phetsims/scenery#1616)

resistance-in-a-wire 1.3-phetio (phetsims/scenery#1616)

resistance-in-a-wire 1.6 (phetsims/scenery#1616)

rutherford-scattering 1.1 (phetsims/scenery#1616)

sound-waves 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

states-of-matter 1.2 (phetsims/scenery#1616)

states-of-matter-basics 1.2 (phetsims/scenery#1616)

trig-tour 1.0 (phetsims/scenery#1616)

under-pressure 1.1 (phetsims/scenery#1616)

unit-rates 1.0 (phetsims/scenery#1616)

vector-addition 1.0 (phetsims/scenery#1616)

vector-addition-equations 1.0 (phetsims/scenery#1616)

wave-interference 2.0 (phetsims/scenery#1616)

wave-on-a-string 1.1 (phetsims/scenery#1616)

waves-intro 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

@jonathanolson
Copy link
Contributor Author

jonathanolson commented Mar 1, 2024

Remaining items from #1039 (comment):

build-a-nucleus 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-ac 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-ac-virtual-lab 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-dc 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

circuit-construction-kit-dc-virtual-lab 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

collision-lab 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

concentration 1.7 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

density 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

energy-skate-park 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

equality-explorer 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

faradays-law 1.4 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

fourier-making-waves 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

friction 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

function-builder 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

function-builder-basics 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

geometric-optics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

geometric-optics-basics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

graphing-quadratics 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gravity-and-orbits 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gravity-and-orbits 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

gravity-force-lab-basics 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

greenhouse-effect 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

greenhouse-effect 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

john-travoltage 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

keplers-laws 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

mean-share-and-balance 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecule-polarity 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecule-shapes 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

molecule-shapes-basics 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

my-solar-system 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.3 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.4 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

natural-selection 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

normal-modes 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-compare 1.0 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-distance 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-integers 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-line-operations 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

number-play 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ph-scale 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ph-scale-basics 1.5 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ph-scale-basics 1.6 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

quadrilateral 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

ratio-and-proportion 1.2 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

sound-waves 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

waves-intro 1.1 (https://github.com/phetsims/website-meteor/issues/656, phetsims/scenery#1616)

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 8, 2024

Noting that instance proxies are not launching. This has been an ongoing problem and is not related to this MR.
phetsims/capacitor-lab-basics#291, #859 (comment)

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 8, 2024

forces-and-motion-basics 2.3-phetio links do not load with this error in the console:
bug

@jonathanolson
Copy link
Contributor Author

forces-and-motion-basics 2.3-phetio links do not load with this error in the console:

I don't think this should block anything. My question from the phet-io channel just now:

It seems that FAMB 2.3-phetio has been enabled (again?) in the phet-io deploys dashboard on the website. It's caused issues with maintenance releases before, and I thought it was disabled.
Long story short, the last non-broken deployment of it was July 2018 (https://phet-io.colorado.edu/sims/forces-and-motion-basics/2.3.2-phetio/forces-and-motion-basics_en-phetio.html?phetioStandalone). It went through a 6-year period of being disabled (and not getting any maintenance patches).
It looks like it was enabled again sometime, and the most recent MR (that only patched build-related things) pushed out a very-broken https://phet-io.colorado.edu/sims/forces-and-motion-basics/2.3.4-phetio/forces-and-motion-basics_en-phetio.html?phetioStandalone. It's now causing issues in the latest MR (#1052 (comment)).
Is it re-enabled for a reason? Any objections to me disabling it again? (The latest release is FAMB 2.2. Yes, that looks like a lower version, we used to version phet-brand and phet-io brand separately). If so, can we consider just going scorched-earth on it somehow, so it doesn't get re-enabled?

@Nancy-Salpepi
Copy link
Contributor

QA is done!

@jonathanolson
Copy link
Contributor Author

I don't see anything blocking, kicking off MR production deploys.

@jonathanolson
Copy link
Contributor Author

Checking production:

acid-base-solutions 1.3 ()

area-builder 1.1 ()

area-model-algebra 1.2 ()

area-model-decimals 1.2 ()

area-model-introduction 1.2 ()

area-model-multiplication 1.2 ()

arithmetic 1.0 ()

atomic-interactions 1.2 ()

balancing-act 1.1 ()

balancing-chemical-equations 1.2 ()

balloons-and-static-electricity 1.3-phetio ()

balloons-and-static-electricity 1.5 ()

beers-law-lab 1.7 ()

bending-light 1.1 ()

blackbody-spectrum 1.0 ()

build-a-fraction 1.0 ()

build-a-molecule 1.0 ()

build-a-nucleus 1.1 ()

build-an-atom 1.5-phetio ()

build-an-atom 1.6 ()

calculus-grapher 1.0 ()

capacitor-lab-basics 1.6 ()

center-and-variability 1.1 ()

charges-and-fields 1.0 ()

charges-and-fields 1.0-phetio ()

circuit-construction-kit-ac 1.0 ()

circuit-construction-kit-ac-virtual-lab 1.0 ()

circuit-construction-kit-dc 1.3 ()

circuit-construction-kit-dc-virtual-lab 1.3 ()

collision-lab 1.1 ()

color-vision 1.1 ()

color-vision 1.2-phetio ()

concentration 1.5-phetio ()

concentration 1.7 ()

coulombs-law 1.0 ()

curve-fitting 1.0 ()

density 1.1 ()

diffusion 1.0 ()

energy-forms-and-changes 1.4 ()

energy-skate-park 1.3 ()

energy-skate-park-basics 1.1 ()

energy-skate-park-basics 1.3-phetio ()

equality-explorer 1.1 ()

equality-explorer-basics 1.0 ()

equality-explorer-two-variables 1.0 ()

expression-exchange 1.1 ()

faradays-law 1.3-phetio ()

faradays-law 1.4 ()

forces-and-motion-basics 2.1-phetio ()

forces-and-motion-basics 2.2-phetio ()

forces-and-motion-basics 2.3 ()

fourier-making-waves 1.0 ()

fraction-matcher 1.2 ()

fractions-equality 1.1 ()

fractions-intro 1.0 ()

fractions-mixed-numbers 1.0 ()

friction 1.6 ()

function-builder 1.2 ()

function-builder-basics 1.2 ()

gas-properties 1.0 ()

gases-intro 1.0 ()

gene-expression-essentials 1.0 ()

geometric-optics 1.3 ()

geometric-optics-basics 1.3 ()

graphing-lines 1.3 ()

graphing-quadratics 1.3 ()

graphing-slope-intercept 1.1 ()

gravity-and-orbits 1.5 ()

gravity-and-orbits 1.6 ()

gravity-force-lab 2.2 ()

gravity-force-lab-basics 1.1 ()

greenhouse-effect 1.0 ()

greenhouse-effect 1.2 ()

hookes-law 1.0 ()

isotopes-and-atomic-mass 1.1 ()

john-travoltage 1.4-phetio ()

john-travoltage 1.6 ()

keplers-laws 1.1 ()

least-squares-regression 1.1 ()

make-a-ten 1.0 ()

masses-and-springs 1.0 ()

masses-and-springs-basics 1.0 ()

mean-share-and-balance 1.0 ()

molarity 1.4 ()

molarity 1.5 ()

molecule-polarity 1.3 ()

molecule-shapes 1.6 ()

molecule-shapes-basics 1.6 ()

molecules-and-light 1.3-phetio ()

molecules-and-light 1.5 ()

my-solar-system 1.3 ()

natural-selection 1.2 ()

natural-selection 1.3 ()

natural-selection 1.4 ()

natural-selection 1.5 ()

neuron 1.1 ()

normal-modes 1.0 ()

number-compare 1.0 ()

number-line-distance 1.1 ()

number-line-integers 1.2 ()

number-line-operations 1.1 ()

number-play 1.1 ()

ohms-law 1.4 ()

pendulum-lab 1.0 ()

ph-scale 1.6 ()

ph-scale-basics 1.5 ()

ph-scale-basics 1.6 ()

plinko-probability 1.1 ()

projectile-motion 1.0 ()

proportion-playground 1.0 ()

quadrilateral 1.1 ()

ratio-and-proportion 1.2 ()

reactants-products-and-leftovers 1.2 ()

resistance-in-a-wire 1.3-phetio ()

resistance-in-a-wire 1.6 ()

rutherford-scattering 1.1 ()

sound-waves 1.1 ()

states-of-matter 1.2 ()

states-of-matter-basics 1.2 ()

trig-tour 1.0 ()

under-pressure 1.1 ()

unit-rates 1.0 ()

vector-addition 1.0 ()

vector-addition-equations 1.0 ()

wave-interference 2.0 ()

wave-on-a-string 1.1 ()

waves-intro 1.1 ()

@jonathanolson
Copy link
Contributor Author

Looks like everything was successful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants