Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardDragListener end listener fired regardless of whether it is currently dragging #1636

Closed
jessegreenberg opened this issue Jun 4, 2024 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

A bug introduced from #1621. If the KeyboardDragListener is not dragging but the Hotkeys indicate it is pressed, the end action will still execute. This is possible if the dragging doesn't start because the Pointer is already attached (interacting with another target already - likely a descendent that got the event first). This should be fixed.

@jessegreenberg
Copy link
Contributor Author

Fixed in the above commit. This is a similar case to #1634. Just like that issue, this was missed in earlier testing because Hotkey generally handles this. But because AccessibleSlider does not use KeyboardListener (and therefore Hotkey), we hit this case. This change is correct for KeyboardDragListener, but AccessibleSlider should be changed to use KeyboardListener.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant