-
Notifications
You must be signed in to change notification settings - Fork 630
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable interpolation of HEREDOC strings containing hook scripts
Interpolation was applied within the user-data.sh context, causing unexpected empty values for variables and other unintentend effects. While this behavior might be useful in certain cases, it requires consistently escaping everything in hook scripts. This approach feels error-prone and unintuitive. For example, the following configuration will echo an empty string and the date of string interpolation, but not the date of the job's start: ``` runner_hook_job_started: | echo $GITHUB_WORKSPACE echo $(date) ```
- Loading branch information
Showing
2 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters