Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image variant with vscode specific settings #314

Merged
merged 23 commits into from
Feb 20, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Feb 17, 2024

This PR adds an additional image that is pre-configured with VS Code specific settings, attached as image labels. These settings are more opinionated than the base image hence the separate image. It is possible to override, amend or change the options following this merge logic.

The intention is to create a ready-to-run image that has a valid configuration for most included tools. E.g. clangd and debugging configurations for the compilers and tools present in the base image.

@rjaegers rjaegers requested a review from a team as a code owner February 17, 2024 09:48
Copy link
Contributor

github-actions bot commented Feb 17, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.02s
✅ DOCKERFILE hadolint 1 0 0.28s
✅ JSON eslint-plugin-jsonc 8 0 0 3.14s
✅ JSON prettier 8 0 0 0.76s
✅ JSON v8r 8 0 3.97s
✅ MARKDOWN markdownlint 7 0 0 0.91s
✅ MARKDOWN markdown-link-check 7 0 6.65s
✅ MARKDOWN markdown-table-formatter 7 0 0 0.26s
✅ REPOSITORY checkov yes no 15.22s
✅ REPOSITORY gitleaks yes no 0.18s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY grype yes no 11.44s
✅ REPOSITORY secretlint yes no 1.41s
✅ REPOSITORY trivy yes no 9.04s
✅ REPOSITORY trivy-sbom yes no 1.68s
✅ REPOSITORY trufflehog yes no 5.38s
✅ SPELL lychee 38 0 2.52s
✅ YAML prettier 14 0 0 1.04s
✅ YAML v8r 14 0 13.29s
✅ YAML yamllint 14 0 0.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Feb 17, 2024

Test Results

18 tests  ±0   18 ✅ ±0   35s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 562ce60. ± Comparison against base commit 7f2ca09.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers enabled auto-merge February 20, 2024 11:45
@rjaegers rjaegers added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 8b9c707 Feb 20, 2024
14 checks passed
@rjaegers rjaegers deleted the feature/image-variant-vscode branch February 20, 2024 12:07
Copy link
Contributor

Pull Request Report (#314)

Static measures

Description Value
Number of added lines 148
Number of deleted lines 34
Number of changed files 6
Number of commits 23
Number of reviews 2
Number of comments (w/o review comments) 2
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 3

Time related measures

Description Value
PR lead time (from creation to close of PR) 3.1 Days
Time that was spend on the branch before the PR was created 2.7 Min
Time that was spend on the branch before the PR was merged 3.1 Days
Time to merge after last review 22.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 21.6 Min
Total time spend in last status check run on PR 15.9 Min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants