Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a first run notice detailing the version of amp-devcontainer #688

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jan 9, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR adds a first-run-notice file that will be displayed when the container is first started displaying the container version number.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner January 9, 2025 09:28
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 21s ⏱️ ±0s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a30a501. ± Comparison against base commit 556d28b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.09s
✅ DOCKERFILE hadolint 2 0 0.52s
✅ GHERKIN gherkin-lint 2 0 0.87s
✅ JSON npm-package-json-lint yes no 0.39s
✅ JSON prettier 15 1 0 1.94s
✅ JSON v8r 14 0 11.35s
✅ MARKDOWN markdownlint 8 0 0 0.77s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 16.51s
✅ REPOSITORY gitleaks yes no 0.24s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.64s
✅ REPOSITORY secretlint yes no 0.95s
✅ REPOSITORY syft yes no 1.19s
✅ REPOSITORY trivy yes no 5.16s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 6.47s
✅ SPELL lychee 59 0 2.15s
✅ YAML prettier 21 0 0 0.64s
✅ YAML v8r 21 0 12.24s
✅ YAML yamllint 21 0 0.38s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:68a6cfffdfa466c1ac72d0d2249cc2fc786f4bc809d7676e447146d43f9ca9f0

OS/Platform Previous Size Current Size Delta
linux/amd64 454.99M 461.39M 6.40M (+1.41%)
linux/arm64 593.18M 599.05M 5.88M (+0.99%)

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:856af4896fa145baa93312239680150abc55f698ca8024b4b14e34a0230de6bf

OS/Platform Previous Size Current Size Delta
linux/amd64 644.91M 686.85M 41.94M (+6.50%)
linux/arm64 636.38M 668.58M 32.21M (+5.06%)

@rjaegers rjaegers marked this pull request as draft January 9, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant