Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict HTMLParser interface to only accept binaries #507

Closed
wants to merge 1 commit into from
Closed

Restrict HTMLParser interface to only accept binaries #507

wants to merge 1 commit into from

Conversation

philss
Copy link
Owner

@philss philss commented Dec 19, 2023

This makes the interfaces simplier. We don't need to support iodata for now yet.

@philss
Restrict HTMLParser interface to only accept binaries
4eb734d 
This makes the interfaces simplier. We don't need to support iodata for
now yet.
@philss
Copy link
Owner Author

philss commented Dec 19, 2023

cc/ @wojtekmach

@ypconstante
Copy link
Contributor

iodata support would be useful on Phoenix LiveView tests, for example. Today Phoenix has the content stored as iodata and converts to binary just to call parse, and because mochi_html adds the <floki> root element, for each parse we ended up with two identical binaries being created.

@philss
Copy link
Owner Author

philss commented Oct 9, 2024

OK, I will keep as it is. Thanks for pointing out, @ypconstante

@philss philss closed this Oct 9, 2024
@philss philss deleted the ps-remove-iodata-from-interface branch October 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philss @ypconstante